search

a-b-street / abstreet

Transportation planning and traffic simulation software for creating cities friendlier to walking, biking, and public transit
https://a-b-street.github.io/docs/
Apache License 2.0
7.7k stars 342 forks source link

Fix wrong serde macro namespace #1135

Closed ACGNnsj closed 8 months ago

ACGNnsj commented 9 months ago

When I tried to build updater, I found these files using serde traits instead of macros questionably.

dabreegster commented 8 months ago

Ah, good catch, thank you! I think these have all been silently working only because of transitive dependencies enabling the feature. I looked through and found every crate in this repo using serde needs derive, so I made 34de7f054dbe9aa54d3599451e2bc0cbe8677e81 to update them all. And from https://serde.rs/derive.html, it looks like it can just be a feature on the main crate, which is less hassle than copying in another dependency to serde_derive to all of the crates.

Thanks again for the PR!