search

a-b-street / docs

Technical and user documentation for A/B Street
Apache License 2.0
12 stars 7 forks source link

Mkirk/style fixups #10

Closed michaelkirk closed 3 years ago

michaelkirk commented 3 years ago

side-by-side layout for elevation/route charts

IMO the elevation chart looked pretty bad blown up to full-width on desktop. Arguably the route overview looked better at full width (before), but I think it's still legible enough, and overall worth the tradeoff.

before

Screen Shot 2021-07-12 at 5 17 16 PM

after

Screen Shot 2021-07-12 at 5 16 37 PM

fix chart style for mdbook

images we scale and crop to fit our layout, but we don't want to do that with charts. This was a bug introduced when porting to mdbook.

before

Screen Shot 2021-07-12 at 5 19 38 PM

after

Screen Shot 2021-07-12 at 5 20 56 PM
dabreegster commented 3 years ago

All 3 style changes LGTM!

michaelkirk commented 3 years ago

I pushed up some additional changes since this is as-of-yet unmerged. If you'd prefer I can open a separate PR.

PTAL!

michaelkirk commented 3 years ago

Fixed the typos, thanks!

dabreegster commented 3 years ago

http://abstreet.s3-website.us-east-2.amazonaws.com/0.2.51/abstreet.html?--dev&system/us/seattle/scenarios/arboretum/weekday.bin&--edits=broadmoor%20access is now live