Closed dabreegster closed 2 years ago
Alright, this is ready! https://a-b-street.github.io/docs/landing_page/ appears to work for me. @dingaaling, it's probably easiest to just read through the commits in https://github.com/a-b-street/docs/pull/35/commits except for the first (a straightforward copy from your repo). I mostly just fixed warnings, added website credits for you and Trang, and added alt text to the images on the carousel.
Actually, you can show a diff from a range of commits. Here's what I changed: https://github.com/a-b-street/docs/pull/35/files/41ad5695dabeb0111f05e4e5b43bed3d2471ad90..afc0bb6e0bade814af5f50cd3abcc31f2e40ff65
The page looks pretty good on desktop - nice work!
The mobile layout could use some improvements however. On my device the text flows off the screen. Here's a screenshot from an iPhone SE 2020:
I think @dingaaling tested on mobile in a previous version -- from the last PR, at least the reduced window width looked pretty good: https://user-images.githubusercontent.com/5104098/169832499-46ad2744-72d8-4f4a-8b1e-8e2f887b1c12.mov
So either we have a regression, or we've got to do more CSS magic?
Pretty sure the fault lies with Grid or ResponsiveAppBar's pop out menu on the right side... will investigate further
I'm going to merge this in and file issues for the next steps
Deployed to https://a-b-street.github.io/docs/landing_page/, but with problems. The
/About
and/Contact
internal routing break, because we're not hosted at the root directory. I thoughthomepage
inpackage.json
would help, but may have more tweaks to makeAlso need to add credits for the website itself!
CC @dingaaling