search

a-b-street / osm2lanes

A common library and set of test cases for transforming OSM tags to lane specifications
https://a-b-street.github.io/osm2lanes/
Apache License 2.0
34 stars 2 forks source link

Rust Lane Count #134

Closed droogmic closed 2 years ago

droogmic commented 2 years ago

An alternative to https://github.com/a-b-street/osm2lanes/pull/111

I copied over a part of @BudgieInWA, complementing it with a hybrid way of handling bus ways...

It is a bit messy, so I can start to split into multiple PRs if needed.

droogmic commented 2 years ago

I think for this to be readable I would have to split it, but that will take some more time :(

droogmic commented 2 years ago

I imagine as soon as we get the bulk of this approach checked in, there will be less confusing merge conflicts for the both of you...

yeah, I am trying to keep getting small stuff in so that we reduce the size of the open WIP

BudgieInWA commented 2 years ago

I have fixed the logic errors in #111, so all that is left is another merge of main, which I am doing right now. I feel that #111 has all that it needs to be merged, and would prefer that we do that instead of going ahead with this PR.

droogmic commented 2 years ago

I have fixed the logic errors in #111, so all that is left is another merge of main, which I am doing right now. I feel that #111 has all that it needs to be merged, and would prefer that we do that instead of going ahead with this PR.

maybe, but can you comment on how I handled the bus lanes. I think this is actually a simpler, more natural, and more extensible way of handling these lanes? I will review your PR as well.

droogmic commented 2 years ago

@BudgieInWA Note: I was actually made this whilst trying to merge your changes, but ended up wanting to simplify your work to get it in in smaller section. Most code here is modified from yours.