search

a-b-street / osm2lanes

A common library and set of test cases for transforming OSM tags to lane specifications
https://a-b-street.github.io/osm2lanes/
Apache License 2.0
34 stars 2 forks source link

Rust: Refactor RoadBuilder and LaneBuilder #138

Closed droogmic closed 2 years ago

droogmic commented 2 years ago

These are two quite big structs, so we begin a refactor by moving them out of mod to allow for better increments

dabreegster commented 2 years ago

Should we merge one of the big bus PRs before creating more merge conflicts?

droogmic commented 2 years ago

Should we merge one of the big bus PRs before creating more merge conflicts?

I find it's a slippery slope to block integration due to big PRs. I want to see if we can start splitting @BudgieInWA's concepts into even smaller pieces.

droogmic commented 2 years ago

I think you're mostly just moving code around here? Sadly git didn't detect it as a move/copy

I... think so as well. Honestly don't remember 100%. I think I split a file in two. Refactoring is one weakness in git review methodology :P