a-b-street / osm2lanes

A common library and set of test cases for transforming OSM tags to lane specifications
https://a-b-street.github.io/osm2lanes/
Apache License 2.0
34 stars 2 forks source link

More edit controls #260

Closed dabreegster closed 2 years ago

dabreegster commented 2 years ago

240

https://user-images.githubusercontent.com/1664407/200313141-793b6aff-1e2f-4bf3-9048-4be609614850.mp4

1) A (+) button to insert a lane at a particular position 2) Add missing card for sidewalks! 3) Click direction arrow to toggle it

A next possible step is clicking the lane type icon to get a little modal popup and choose the type. So then inserting a lane and changing the type would become much more fluid

github-actions[bot] commented 2 years ago

Benchmark for 7126333

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | tests/224637155 | **5.4±0.02µs** | 5.5±0.01µs | **+1.85%** | | tests/380103730 Japanese Expressway | 7.1±0.01µs | 7.1±0.01µs | 0.00% | | tests/389654080 | 9.0±0.01µs | 9.0±0.02µs | 0.00% | | tests/49207928 cycleway:BACKWARD=lane | 6.6±0.01µs | 6.6±0.01µs | 0.00% | | tests/8591383 a bidirectional cycleway, oneway:bicycle | 7.5±0.00µs | **7.4±0.01µs** | **-1.33%** | | tests/bus:lanes=designated\| | 6.8±0.02µs | 6.8±0.02µs | 0.00% | | tests/busway=lane | 6.2±0.02µs | 6.2±0.02µs | 0.00% | | tests/cycleway=lane | **6.3±0.01µs** | 6.4±0.07µs | **+1.59%** | | tests/cycleway=opposite oneway=yes oneway:bicycle=no | 6.0±0.01µs | 6.0±0.02µs | 0.00% | | tests/cycleway=opposite_track oneway=yes, deprecated | 6.9±0.01µs | 6.9±0.01µs | 0.00% | | tests/sidewalk:right=yes | **5.6±0.01µs** | 5.7±0.02µs | **+1.79%** | | tests/sidewalk=both | 5.8±0.02µs | 5.8±0.01µs | 0.00% |
github-actions[bot] commented 2 years ago

Benchmark for d8065de

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | tests/224637155 | **5.4±0.00µs** | 5.5±0.02µs | **+1.85%** | | tests/380103730 Japanese Expressway | **7.1±0.01µs** | 7.2±0.08µs | **+1.41%** | | tests/389654080 | 9.0±0.01µs | 9.0±0.01µs | 0.00% | | tests/49207928 cycleway:BACKWARD=lane | 6.6±0.05µs | 6.6±0.01µs | 0.00% | | tests/8591383 a bidirectional cycleway, oneway:bicycle | 7.4±0.00µs | 7.4±0.01µs | 0.00% | | tests/bus:lanes=designated\| | 6.8±0.01µs | 6.8±0.02µs | 0.00% | | tests/busway=lane | **6.1±0.02µs** | 6.2±0.04µs | **+1.64%** | | tests/cycleway=lane | 6.3±0.01µs | 6.3±0.04µs | 0.00% | | tests/cycleway=opposite oneway=yes oneway:bicycle=no | **5.9±0.01µs** | 6.0±0.01µs | **+1.69%** | | tests/cycleway=opposite_track oneway=yes, deprecated | **6.9±0.01µs** | 7.0±0.01µs | **+1.45%** | | tests/sidewalk:right=yes | **5.5±0.02µs** | 5.6±0.01µs | **+1.82%** | | tests/sidewalk=both | **5.7±0.01µs** | 5.8±0.02µs | **+1.75%** |
github-actions[bot] commented 2 years ago

Benchmark for 9cf476a

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | tests/224637155 | 5.4±0.01µs | 5.4±0.01µs | 0.00% | | tests/380103730 Japanese Expressway | **7.1±0.02µs** | 7.2±0.08µs | **+1.41%** | | tests/389654080 | 8.8±0.01µs | 8.8±0.01µs | 0.00% | | tests/49207928 cycleway:BACKWARD=lane | 6.6±0.01µs | **6.5±0.01µs** | **-1.52%** | | tests/8591383 a bidirectional cycleway, oneway:bicycle | 7.3±0.01µs | 7.3±0.01µs | 0.00% | | tests/bus:lanes=designated\| | 6.7±0.01µs | 6.7±0.01µs | 0.00% | | tests/busway=lane | 6.0±0.01µs | 6.0±0.01µs | 0.00% | | tests/cycleway=lane | 6.2±0.01µs | 6.2±0.01µs | 0.00% | | tests/cycleway=opposite oneway=yes oneway:bicycle=no | 5.9±0.01µs | **5.8±0.01µs** | **-1.69%** | | tests/cycleway=opposite_track oneway=yes, deprecated | **6.8±0.01µs** | 6.9±0.01µs | **+1.47%** | | tests/sidewalk:right=yes | 5.4±0.01µs | 5.4±0.01µs | 0.00% | | tests/sidewalk=both | 5.7±0.01µs | 5.7±0.01µs | 0.00% |