search

a-b-street / osm2lanes

A common library and set of test cases for transforming OSM tags to lane specifications
https://a-b-street.github.io/osm2lanes/
Apache License 2.0
34 stars 2 forks source link

Use nightly for cargo fmt check in CI #53

Closed dabreegster closed 2 years ago

dabreegster commented 2 years ago

I wasn't familiar with git hooks, but they indeed have advantages. @enzet, any thoughts about consolidating the github actions and git hooks?

dabreegster commented 2 years ago

Urgh, the setup rust action is harder to understand than rustup. It's switching the default to nightly. I'll work on this later

enzet commented 2 years ago

I'm not familiar with cargo, but the the idea of keeping them consistent with GitHub Actions looks right.

The only problem with Git hooks is that they have be enabled by committer manually with

git config --local core.hooksPath data/githooks

I think we should add it to README.md or to CONTRIBUTING.md.

droogmic commented 2 years ago

Fixed by #58