a-b-street / osm2streets

Convert OSM to street networks with detailed geometry
https://a-b-street.github.io/osm2streets
Apache License 2.0
102 stars 9 forks source link

Remove the transformation that shrinks overlapping roads. #167

Closed dabreegster closed 1 year ago

dabreegster commented 1 year ago

159

This is indeed too blunt an instrument. I considered keeping it just for A/B Street, but I don't really want to rely on things we're not testing here, and it's only slightly helping in some situations that're broken anyway.

Some particularly notable regressions (where we were just kind of getting lucky before): Screenshot from 2023-01-03 16-04-50 Screenshot from 2023-01-03 16-04-45 Screenshot from 2023-01-03 16-02-41 Screenshot from 2023-01-03 16-02-35

These were problems that came up in https://github.com/a-b-street/osm2streets/issues/136#issuecomment-1365287556. I think merging this first will make the transition to geometry-as-an-operation easier.

dabreegster commented 1 year ago

Noting that in the first example (seattle_slip_lane), there's overlap because we incorrectly infer sidewalks