a-b-street / osm2streets

Convert OSM to street networks with detailed geometry
https://a-b-street.github.io/osm2streets
Apache License 2.0
102 stars 9 forks source link

Always maintain road trims and intersection geometry #168

Closed dabreegster closed 1 year ago

dabreegster commented 1 year ago

Finally finally we're wrapping up #136. The code is hopefully easier to understand now, and the results are slowly improving. The order updates and transformations happen is still sensitive and we'll have to do something more rigorous in #159.

Before this PR, I got rid of shrinking roads in #167 and updated one test's OSM data in 2b89cc120c45940d5a2b3e861c598d01cc78b598. This reduced the diff from this PR and made it easier to understand the subtle ordering between things.

A sample of changes. Nothing gets much worse; lots of places change in kind of neutral ways. Highlights: kingsway_junction: Screenshot from 2023-01-03 18-24-58 Screenshot from 2023-01-03 18-25-05

quad_intersection Screenshot from 2023-01-03 18-26-28 Screenshot from 2023-01-03 18-26-33

seattle_slip_lane: Screenshot from 2023-01-03 18-27-13 Screenshot from 2023-01-03 18-27-09

tempe_light_rail: Screenshot from 2023-01-03 18-28-19 Screenshot from 2023-01-03 18-28-16

Actually going to not merge this one until a review, since it's pretty important

dabreegster commented 1 year ago

Ping @BudgieInWA

dabreegster commented 1 year ago

Going to merge and work on a few smaller fixes, but still some questions here I'd love feedback on later