search

a-dekker / smpc

Official port of Qt/Qml based qmobilempd MPD Client. (From symbian)
Other
4 stars 7 forks source link

currentplaylist trackdelegate #16

Closed fuchsmich closed 4 years ago

fuchsmich commented 4 years ago

I couldn't test "Add to saved playlist" here.

a-dekker commented 4 years ago

Is this related to the "show artist" issue I mentioned yesterday? I would like to have a "no regressions" situation first, then make a new release before moving on other changes.

fuchsmich commented 4 years ago

Is this related to the "show artist" issue I mentioned yesterday?

Yes, absolutely.

I reverted some of my changes for this and simplified some code. I also discovered, that "Play as next" had a bug introduced by me.

But I can't test saved playlists at my current computer.

a-dekker commented 4 years ago

Good to know, I will see if I can test "add to saved playlist".

a-dekker commented 4 years ago

Add to saved playlists seems to work fine. Only thing I notice is this message on the console:

[W] unknown:207 - file:///usr/share/harbour-smpc/qml/pages/database/PlaylistTracksPage.qml:207: ReferenceError: clearPlaylistTracks is not defined

fuchsmich commented 4 years ago

I search for clearPlaylistTracks (also in old code), but couldn't find the function referenced here. So this error maybe already existed for a long time. It does not harm, but I will comment it out.

a-dekker commented 4 years ago

That's most likely the case than.