a-dekker / smpc

Official port of Qt/Qml based qmobilempd MPD Client. (From symbian)
Other
4 stars 7 forks source link

Radio Station Names #41

Closed sh6668 closed 2 years ago

sh6668 commented 2 years ago

Hi

in playlists with Radio Stations the complete URL/filename is shown. it's often unreadable.

In playlist generated by cantata the name is behind a '#' in the URL. In m3u playlists mpd shows the correct name in the Name Tag. If i write this information to MpdTrack->title it's shown correctly.

i would like to change this and create a pullrequest.

a-dekker commented 2 years ago

I normally do not use playlists and or/url streams. But improving readability sounds fine of course.

Please create a PR, and I will see if I can so some tests to see the actual difference.

a-dekker commented 2 years ago

Referring PR: https://github.com/a-dekker/smpc/pull/42

a-dekker commented 2 years ago

Could you provide an example m3u file? A have a small playlist, but can't really see a difference with Cantata.

I have something like

http://8bit.fm:8000/main
http://stream.chipbit.net:8000/autodj.m3u

In my internet radio playlist, and it shows up the the same, no '#' etc. Are we talking about some native Cantata format?

a-dekker commented 2 years ago

Released in 1.3.25.1

kan-ibal commented 2 years ago

While "#" is already implemented is it possible to implement "StreamName" URL format? e.g http://109.74.196.76/proxy/onlinerhb?mp=/stream#StreamName=Radio%20Hospitals%20Blackburn

a-dekker commented 2 years ago

StreamName seems to be some non standard key name in the comment to me, as I do not really see it used elsewhere. Since it is just comment, you can remove the "StreamName=" in the URL for it to be handled as regular comment.

kan-ibal commented 2 years ago

I use radio playlist in m3u format located in /var/lib/mpd/playlists prepared in Canata(->Playlists->Stored Playlists) using simple drag&drop so I can reach them directly from SMPC->Files. It looks like Cantata adds this comment as well as "#" so all of my streams got this comment :).

a-dekker commented 2 years ago

Added a stream via Add stream in Cantata (URL and name), and indeed it added a "StreamName=" to the URL. I am afraid it is very Cantata specific, but it should be doable to remove this substring.

a-dekker commented 2 years ago

This commit should fix this: https://github.com/a-dekker/smpc/commit/1724f8cf8f6d8a45e0279b1d2efe783ab05ff831 But keep in mind: Cantana creates the comment in html escaped format. This means non standard characters should be translated to plain text. There in no proper Qt/C++ function to do that afaik. At the moment I just replace the space character, which is sufficient for your case, but could be refined more for other cases.

a-dekker commented 2 years ago

Released in 1.3.26.1

kan-ibal commented 2 years ago

Great. Appreciate your work.