list albums (all and artist)

[fuchsmich]

I rewrote most of the c++ code listing albums. I tested with 0.19 from debian oldstable, 0.21 from debian stable and current mpd on arch (thanks to docker it's easy to run different versions of mpd).

Albumlist:

• Albums without name are skipped
• Albums are grouped by musicbrainzid (if available)
• Albums are grouped by albumartist (if available and selected in settings)

Albumlist for Artist:

• Albums can be sorted by year, and section reflects this.

[a-dekker]

I'll test your changes on short notice myself, thanks for your work so far.

[a-dekker]

I've walked though the diffs and did not notice any worrying changes. But keep in mind I am not a C++ programmer. Furthermore played a bit with a compiled version of your a-devel branch and I did not notice issues. So I guess we have to wait until you get this PR out of draft state when it's finalized?

[fuchsmich]

Yes, I just have to sort out, where the changes come from in other parts of the code and what theses changes are for. I'm afraid I overwrote some old changes.

[fuchsmich]

ok, could you please test the last commit? for me it works for songs, album and artists with quotes.

But there are a lot of other places in the code, where I think the arguments should be escaped as well...

[a-dekker]

Yes, I am able to play the album once again. I also did some related changes for the coverart: https://github.com/a-dekker/smpc/commit/9568ff8af2ba917f64216860f4e1a64fc314f9b9 (change in src/localdb/imagedatabase.cpp )

[fuchsmich]

Some clean up. The fix in imagedatabase.cpp is still present.

[a-dekker]

The fix in imagedatabase.cpp is still present.

I know, but I was using it as an example referring to you remark that in other places arguments should be escaped as well.