a-digital / cookie-consent-banner

Add a configurable cookie consent banner to the website.
MIT License
11 stars 13 forks source link

Cookie banner not appearing on Craft commerce #30

Open JayBox325 opened 3 years ago

JayBox325 commented 3 years ago

We have a full eCommerce project and the cookie banner is appearing for all pages except for those within our commerce templates directory (cart, product, shop landing etc).

Is this by design, a bug or something we've misconfigured?

CraftCMS: 3.5.14 Commerce: 3.2.8.1 Cookie Banner: 1.2.7

Thanks!

mark-adigital commented 3 years ago

Sorry for the lag in replying. I've never encountered this before - however there's several settings around whether the banner should be auto-injected for all pages and whether it should be excluded from certain entry types/categories. I'm wondering if you have disabled auto-injection, and then the templates where the banner isn't being displayed resolve down to Commerce product types rather than entries or categories?

If so, the easiest fix in the short term would be to auto-inject the banner on all pages (unless there's particular pages where you really don't want it to display) and I'll look to add in Commerce product types as a new setting in the next release. Obviously there's a lot going on in the world right now and this is a free plugin, but there's been a couple of requests recently so I will aim to get something else out in the next 6-8 weeks or so.

john-henry commented 3 years ago

+1 for this feature. Currently, it does not display on any product pages on website. Ironically the only pages where we use cookies!

john-henry commented 2 years ago

Added support for Craft Commerce here https://github.com/a-digital/cookie-consent-banner/pull/39