a-dilettante / HackerBuzz-ReactNative

A Hacker News Reader built in React Native for iOS and Android
MIT License
231 stars 66 forks source link

Swipable Tabs #2

Open deadcoder0904 opened 7 years ago

deadcoder0904 commented 7 years ago

Currently swiping from the side doesn't work.

Like if I am on New tab & swipe left then it should take me to Top tab but it does not work.

a-dilettante commented 7 years ago

The main reason why it's disabled, it's because if you swipe from the left-hand-side of an item, then it'll try and favorite and that would conflict with swipe-able tabs.

It's this prop that's causing the swiping to be disabled

deadcoder0904 commented 7 years ago

Yep, that's true but I think that looks weird kinda. If you want to favorite you can double-tap & enabling Tab Views would be much better I guess. This might be much better DX.

& its kinda trouble to move your finger all the way above to click tabs rather than swipe. Bcz if I want to use this app, I want it to be less time-consuming & much faster.