search

a-h / templ

A language for writing HTML user interfaces in Go.
https://templ.guide/
MIT License
7.14k stars 236 forks source link

Release `v0.2.731` breaks Mason.nvim integration #823

Closed zyriab closed 1 day ago

zyriab commented 2 days ago

Hello! First off, amazing job with Templ, this is amazing!

I am using Mason with Neovim to manage my LSPs, Linters, DAPs, etc but I can't get the Templ LSP to work properly with it. I spent a few hours debugging my config and I found out that the problem is that the Mason registry uses the latest release, not the latest version of the code on the main branch.

If I ditch Mason and use go install pointing to the latest version, I get the v0.2.734 which works just fine: auto-imports, auto-completion, etc.

Since my entire LSP config turns around Mason, I can't (and won't) ditch it easily, so I wanted to ask: can you make a release with the current version of the main branch?

Thanks and take care :)

joerdav commented 1 day ago

I would expect the latest release v0.2.731 to work fine as-well. Can you please outline exactly what has broken in this version?

joerdav commented 1 day ago

Are you experiencing the bug fixed in https://github.com/a-h/templ/commit/01d33616aadcc08e450a95f7bce086e7f44662c5 ?

It is worth mentioning that you can tell mason not to install an lsp and use the version installed to your PATH, this is what I do since often I am working on a local version of templ.

zyriab commented 1 day ago

Hey, thanks for taking the time to answer! I'm not sure what breaks what, I just don't have all LSP capabilities with Mason's version. The problem might be somewhere else, though. I just don't have much time to investigate.

I'll circumvent using Mason for the moment, sorry for the bother :)

Cheers

EDIT: it seems that it has nothing to do with the release itself, it looks like there's something going on with my config. I'll keep investigating but it seems the problem is on Mason's side or, at least, caused by it. Closing the issue.

EDIT: after investigating, it's an issue with the new version of gopls 0.16.x, my issue is related to #801

a-h commented 20 hours ago

Thanks @zyriab - should now be fixed in https://github.com/a-h/templ/commit/26c1d79761e7800837caffdd3c8c2abab96e0794

zyriab commented 20 hours ago

Thanks @zyriab - should now be fixed in https://github.com/a-h/templ/commit/26c1d79761e7800837caffdd3c8c2abab96e0794

You're the best! I appreciate all the hard work you're putting in!