jimhester commented 3 years ago

In readr 2.0.0 the way that literal string data is passed to readr has changed. Previously any length 2+ character vector was treated as literal data, now these vectors are treated as multiple file names to be read into one dataset.

To specify literal data you can use wrap it in I(), which is what this change does.

Without this change the tests will break when readr 2.0.0 is submitted. We expected to submit readr in 3-5 weeks from now.

You will need to make these changes and submit a new version to avoid errors on CRAN.

codecov-commenter commented 3 years ago

Codecov Report

Merging #2 (1fe3a5b) into master (e71513a) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files           2        2           
  Lines         260      260           
=======================================
  Hits          246      246           
  Misses         14       14

Impacted Files	Coverage Δ
R/eyelink_parser.R	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e71513a...1fe3a5b. Read the comment docs.

a-hurst commented 3 years ago

@jimhester Great, thank you so much! I'll try and submit a 0.2.1 including this fix to CRAN in the next couple days.

a-hurst / eyelinker

Changes for readr 2.0.0 #2

Codecov Report