search

a-laarabi / spaceTravelers-Hub

MIT License
1 stars 0 forks source link

Kanban board #21

Open Lusindiso opened 1 year ago

Lusindiso commented 1 year ago

We are a team of 2. https://github.com/a-laarabi/spaceTravelers-Hub/projects/1

phelian23 commented 1 year ago

Hi @Team,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Good job copying the template

Required Changes ♻️

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

You can also consider:

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Nemwel-Boniface commented 1 year ago

Hello @Lusindiso and @a-laarabi :wave: ,

I am Nemwel your reviewer for this PR :man_beard:

Thank you for making the requested changes good job! :partying_face: Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! :partying_face: 🎉

Highlights

Great job setting up the correct linters ✔️ Professional documentation ✔️ Correct workflow ✔️ Meaningful commit messages ✔️ Met all the milestone requirements ✔️

[Optional] suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @Nemwel-Boniface in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.