search

a-luna / fastapi-redis-cache

A simple and robust caching solution for FastAPI that interprets request header values and creates proper response header values (powered by Redis)
MIT License
154 stars 24 forks source link

How can I cache POST requests? #64

Closed kishvanchee closed 2 years ago

kishvanchee commented 2 years ago

Hi, thank you for the library. Is there any way I can cache the POST requests as well? My use case is we do not change any resource per se in the server but we use POST to allow request body to have some parameters. There are high chances for repeated requests with the same combination. Can you please suggest how I can proceed with this using your library?

I also don't mind caching manually if the above solution is not possible. If manual caching is possible with your library, please let me know how I can do that.

kishvanchee commented 2 years ago

I tried this out and it looks like even POST requests get cached as long as the return value of the API endpoint function is JSON serializable.

kishvanchee commented 2 years ago

I ended up monkey patching this for the instance method and redefining what I wanted as https://github.com/a-luna/fastapi-redis-cache/blob/233835b1a2265423bacb73c81d41c12676d2f7fc/src/fastapi_redis_cache/client.py#L14 Allowed HTTP methods as GET and POST

mayurpande commented 2 years ago

@kishvanchee Do you use this in production? As I want to do the same, my output data is JSON. However I do have an asynchronous dask client call in the view. But as the output is the same depending on input I think this should be ok right?

utk231 commented 1 year ago

@mayurpande @kishvanchee Could you please share the response format snippet where it returns json in fastapi. The JSONResponse actually returns Object of type <class 'starlette.responses.JSONResponse'>

INFO:fastapi_redis_cache.client: 06/30/2023 04:53:06 AM | FAILED_TO_CACHE_KEY: Object of type <class 'starlette.responses.JSONResponse'> is not JSON-serializable: