search

a-marenkov / gsheets

A Dart library for working with Google Sheets API.
Other
79 stars 31 forks source link

Add BatchUpdate #12

Closed piecubed closed 4 years ago

piecubed commented 4 years ago

First version of a BatchUpdate class. Totally open to any changes!

piecubed commented 4 years ago

Oh, I just saw https://github.com/a-marenkov/gsheets/blob/master/lib/src/gsheets.dart#L132 Well, this can be a nice user facing way I guess

a-marenkov commented 4 years ago

Oh, I just saw https://github.com/a-marenkov/gsheets/blob/master/lib/src/gsheets.dart#L132 Well, this can be a nice user facing way I guess

Hi, i merged https://github.com/a-marenkov/gsheets/pull/10 and rolled out new dev version of gsheets with createSpreadsheet. I also added batchUpdate method to Spreadsheet and exposed one in Gsheets here is the commit.

This way it might be sufficient for batch update functionality, what do you think? Or you'd prefer to have BatchUpdate class?

Thanks for contributing and enthusiasm :)

P.S. Actually, i've planed to create class Table that holds mutable rows and columns and has a sync method. So user would fetch the worksheet, manimpulate it, change its cells and then just sync it. But i have not thought this through and i don't really have the time for it now.

piecubed commented 4 years ago

@a-marenkov I'm going to be on summer break soon, so if you could create a project with some specific things you would like to add, I'd be happy to make PRs.

piecubed commented 4 years ago

I kind of like the idea of an actual queue you can change later, and apply to more than one spreadsheet, like a template, so I would say a class might be better. For a mutable sync spreadsheet, this might be better, because it would already have the queue implemented. It's not hard to make a queue though, so it's up to you if you want to merge this or not.

piecubed commented 4 years ago

Any thoughts on this?

a-marenkov commented 4 years ago

Any thoughts on this?

Well, i'm not against the BatchUpdate class, but i don't really see what this implementation brings.

I think users can create list of requests by themselves and then call Gsheets.batchUpdate if they want to apply them to more than one spreadsheet or if they don't want to fetch the spreadsheet beforehand, otherwise they can use batchUpdate of Spreadsheet class.

This implementation also forces them to use googleapis library (i don't know it might be good, might be not).

So again, i'm not against the BatchUpdate class, i just need to think about it.

piecubed commented 4 years ago

@a-marenkov Could you make a project for this repo? Just put things you want to be implemented in there, as I don't really know what you want to happen next.

a-marenkov commented 4 years ago

@a-marenkov Could you make a project for this repo? Just put things you want to be implemented in there, as I don't really know what you want to happen next.

I've created project https://github.com/a-marenkov/gsheets/projects/1

So far i've planned only adding class Table.