a-parhom / LightlyShaders

Rounded window corners and outline effect for KWin.
350 stars 23 forks source link

Fix build for KDE 6.1 #146

Closed sr-tream closed 1 week ago

scgm0 commented 1 week ago

Is there any difference between this PR and https://github.com/a-parhom/LightlyShaders/pull/144?

sr-tream commented 1 week ago

Is there any difference between this PR and #144?

I didn't look at this PR, when creates own.

144 looks more safe in work with OGL context, but didn't fix linking with xcb

AldanTanneo commented 1 week ago

Is there any difference between this PR and #144?

I didn't look at this PR, when creates own.

144 looks more safe in work with OGL context, but didn't fix linking with xcb

I can add a commit to mine to fix the linking if you want, it's just that I didn't run into the issue when I built it

sr-tream commented 1 week ago

Is there any difference between this PR and #144?

I didn't look at this PR, when creates own.

144 looks more safe in work with OGL context, but didn't fix linking with xcb

I can add a commit to mine to fix the linking if you want, it's just that I didn't run into the issue when I built it

Yes, adds it please

AldanTanneo commented 1 week ago

@sr-tream I don't understand why the xcb randr component is needed however

sr-tream commented 1 week ago

@sr-tream I don't understand why the xcb randr component is needed however

It's provided some symbol, what required on my laptop to build with kwin 6.1.0. Currently, I tested it on PC with kwin 6.1.1, and it works without linking with xcb and xcb-randr