German letters öäü support.

a-r-d / url-safe-string

Dependency free node module to convert strings to URL-safe tags for client side routing, SEO purposes, or, whatever else.

8 stars 2 forks source link

German letters öäü support. #2

Open ThibaultJanBeyer opened 7 years ago

ThibaultJanBeyer commented 7 years ago

Hey, good job with your url-safe-string plugin!

However, I noticed that germany letters öäü will also be removed. Ideally those would be replaced with oe, ae and ue. Google Bots understand that.

I’d like to add that functionality, is this a welcome feature contribution right now?

Just let me know, greeting

a-r-d commented 6 years ago

@ThibaultJanBeyer sorry just looking through all of my old projects and seeing your issue. Yes if you are still interested please do a PR, I would be happy to look at it.