Closed rg314 closed 2 years ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
:exclamation: No coverage uploaded for pull request base (
master@42adaef
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #100 +/- ##
=========================================
Coverage ? 40.24%
=========================================
Files ? 48
Lines ? 2805
Branches ? 0
=========================================
Hits ? 1129
Misses ? 1676
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 42adaef...653092d. Read the comment docs.
Success! Thanks for the contribution, Ryan!
Reference Issues/PRs
Fixes #69
What does this implement/fix? Explain your changes.
I have added two docker compose files that enables users to build graphein locally on CPU and GPU (given Nvidia container toolkit is installed). This makes it easy to get the code up and running in a dev and usage env. As per #69 I haven't connected the container to a jupyter notebook because I prefer to mount the container in VS code.
One important note is that graphein is not cloned and installed in the container but the local volume is mapped into the container. This means if the container fails you will still have any changes locally rather than in the contianer file system.
What testing did you do to verify the changes in this PR?
To test the PR I also created
.github/workflows/code-tests-docker.yaml
that will run tests on the CPU built container for CICD. I tested these changes locally on GPU by:Docker & docker-compose versions:
Hardware and OS: