a-r-j / graphein

Protein Graph Library
https://graphein.ai/
MIT License
1.03k stars 131 forks source link

[Bugfix] improve handling of insertions and altlocs #98 #107

Closed a-r-j closed 2 years ago

a-r-j commented 2 years ago

Reference Issues/PRs

98 #105

What does this implement/fix? Explain your changes

Adds example test for troublesome PDB with lots of insertions & altlocs.

What testing did you do to verify the changes in this PR?

codecov-commenter commented 2 years ago

Codecov Report

Merging #107 (6e65c57) into master (8123f42) will increase coverage by 0.85%. The diff coverage is 70.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   40.27%   41.13%   +0.85%     
==========================================
  Files          48       49       +1     
  Lines        2811     2920     +109     
==========================================
+ Hits         1132     1201      +69     
- Misses       1679     1719      +40     
Impacted Files Coverage Δ
graphein/protein/visualisation.py 15.65% <0.00%> (-0.57%) :arrow_down:
graphein/protein/utils.py 53.33% <70.00%> (+2.11%) :arrow_up:
graphein/protein/subgraphs.py 73.07% <73.07%> (ø)
graphein/__init__.py 100.00% <100.00%> (ø)
graphein/protein/__init__.py 84.61% <100.00%> (+1.28%) :arrow_up:
graphein/protein/graphs.py 72.22% <100.00%> (+0.52%) :arrow_up:
graphein/_version.py 0.00% <0.00%> (-12.91%) :arrow_down:
graphein/protein/features/sequence/embeddings.py 34.61% <0.00%> (-1.24%) :arrow_down:
graphein/utils/pymol/core.py 31.74% <0.00%> (-0.52%) :arrow_down:
graphein/ml/conversion.py 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4aed308...6e65c57. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication