a-r-j / graphein

Protein Graph Library
https://graphein.ai/
MIT License
1.03k stars 131 forks source link

Subgraphs #110

Closed a-r-j closed 2 years ago

a-r-j commented 2 years ago

Reference Issues/PRs

104

What does this implement/fix? Explain your changes

Adds secondary structure and surface-based subgraphs & tests. Minor bugfix to RSA calculation where it would fail if it was the only/first DSSP feature computed. Adds GraphConfigurationError exception.

What testing did you do to verify the changes in this PR?

Added tests for the new functions.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov-commenter commented 2 years ago

Codecov Report

Merging #110 (48fe654) into heatmap (3de81c7) will increase coverage by 2.33%. The diff coverage is 74.35%.

Impacted file tree graph

@@             Coverage Diff             @@
##           heatmap     #110      +/-   ##
===========================================
+ Coverage    38.78%   41.12%   +2.33%     
===========================================
  Files           50       50              
  Lines         3117     3154      +37     
===========================================
+ Hits          1209     1297      +88     
+ Misses        1908     1857      -51     
Impacted Files Coverage Δ
graphein/protein/features/nodes/amino_acid.py 80.43% <50.00%> (-3.29%) :arrow_down:
graphein/protein/utils.py 68.00% <60.00%> (+14.66%) :arrow_up:
graphein/protein/subgraphs.py 73.64% <76.00%> (+0.56%) :arrow_up:
graphein/protein/features/nodes/dssp.py 90.12% <100.00%> (+65.44%) :arrow_up:
graphein/protein/graphs.py 74.21% <0.00%> (+0.62%) :arrow_up:
graphein/utils/utils.py 37.16% <0.00%> (+2.65%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3de81c7...48fe654. Read the comment docs.