Closed avivko closed 2 years ago
@a-r-j do you want to fix it or should I have a go at it?
I've penciled in finishing a few pending PRs today. If you want it fast, I'd appreciate a contribution :)
Should be an easy fix: I think it's just missing a .pdb
extension in this line: https://github.com/a-r-j/graphein/blob/1c87afdcba4ce45c17242c8e74d2a1d60d6b9076/graphein/protein/features/nodes/dssp.py#L121
Was just about to work on the hotfix, but I see @OliverT1 was quicker than I was :) Hopefully the PR will be merged soon!
Describe the bug When using a local pdb file and a ProteinGraphConfig that contains a DSSPConfig, DSSPConfig always tries to download the pdb file, even if it is in the pdb_dir, and throws an error if the name of the pdb file is not a PDB ID.
To Reproduce
Results in:
Whereby this also happens when the file is placed in the pdb_dir:
Expected behavior
Desktop (please complete the following information):