kamurani commented 2 years ago

Fixes #15

Add capability to use rsa and dim_[1-7] of the meiler embeddings as features by which the node size is scaled in protein.visualisation.plotly_protein_structure_graph.

Testing by plotting graph: rsa-node-size

a-r-j commented 2 years ago

LGTM, happy to merge. Could you quickly pull this up to head to incorporate the latest changes so tests can run?

kamurani commented 2 years ago

@a-r-j sure thing; although I'm not exactly sure how I would go about doing that. This is the first time i've submitted a PR sorry!

Do you want me to re-commit to the already existing pull request? Or is there a simpler way?

Cheers

codecov-commenter commented 2 years ago

Codecov Report

Merging #186 (024e7a0) into master (8123f42) will increase coverage by 7.98%. The diff coverage is 52.10%.

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   40.27%   48.25%   +7.98%     
==========================================
  Files          48       92      +44     
  Lines        2811     5326    +2515     
==========================================
+ Hits         1132     2570    +1438     
- Misses       1679     2756    +1077

Impacted Files	Coverage Δ
graphein/grn/parse_trrust.py	`37.77% <ø> (ø)`
graphein/ml/diffusion.py	`0.00% <0.00%> (ø)`
graphein/ppi/edges.py	`100.00% <ø> (ø)`
graphein/ppi/graph_metadata.py	`0.00% <ø> (ø)`
graphein/ppi/graphs.py	`54.34% <ø> (ø)`
graphein/ppi/parse_biogrid.py	`75.00% <ø> (ø)`
graphein/ppi/visualisation.py	`0.00% <0.00%> (ø)`
graphein/protein/analysis.py	`0.00% <0.00%> (ø)`
graphein/protein/features/sequence/utils.py	`28.00% <0.00%> (+3.00%)`	:arrow_up:
graphein/protein/features/utils.py	`27.77% <0.00%> (ø)`
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 011d880...024e7a0. Read the comment docs.