Closed manonreau closed 1 year ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
1.1% Duplication
Base: 40.27% // Head: 47.93% // Increases project coverage by +7.66%
:tada:
Coverage data is based on head (
2693ecd
) compared to base (8123f42
). Patch coverage: 52.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Reference Issues/PRs
The centroid coordinates of protein graphs contain NaN values when the PDB file contains at least one insertion and when
{'insertions': True}
is provided to ProteinGraphConfigWhat does this implement/fix? Explain your changes
Adding the
insertion
identifier in the node_id and in the centroid atom grouping function solves the problemWhat testing did you do to verify the changes in this PR?
Graph creation for 1i7z. ex: before modifications: ['A:ASP:1', 'A:LEU:2', 'A:PRO:95', 'A:TRP:96', ...]
G.coords #=> contains NaNs
after modifications:before modifications: ['A:ASP:1', 'A:LEU:2', 'A:PRO:95', 'A:TRP:96', ...]G.coords #=> no NaN
Pull Request Checklist
./CHANGELOG.md
file (if applicable)./graphein/tests/*
directories (if applicable)./notebooks/
(if applicable)python -m py.test tests/
and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,python -m py.test tests/protein/test_graphs.py
)black .
andisort .