Closed a-r-j closed 1 year ago
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
1 Security Hotspot
4 Code Smells
No Coverage information
0.0% Duplication
@amorehead I've added the clustering utils - does this cover what you were hoping for?
You also mentioned some structural clustering - I also think this would be good. Do you have a preferred method?
Hi, @a-r-j.
All these changes look great! I've gone ahead and created another pull request using a personal fork of Graphein
's latest master
branch. In particular, I've revised some of the documentation for each class method, and more importantly, I've added initial support for splitting the e.g., clustered sequence dataset into an arbitrary number of "splits" (e.g., train
, val
, and test
). Also, feel free to push changes directly to this forked branch of mine if you would like to make additions or edits to it. My hope is that we can use this pull request to finish developing the remaining functionality listed. Let me know if you have any questions, comments, or concerns.
Looking forward to the final result!
Reference Issues/PRs
270 @amorehead
What does this implement/fix? Explain your changes
Adds a utility for creating selections of experimental PDB structures
What testing did you do to verify the changes in this PR?
WIP
Draws the following metadata:
Currently missing:
Pull Request Checklist
./CHANGELOG.md
file (if applicable)./graphein/tests/*
directories (if applicable)./notebooks/
(if applicable)python -m py.test tests/
and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,python -m py.test tests/protein/test_graphs.py
)black .
andisort .