search

a-r-m-i-n / min

TYPO3 CMS extension "min" - Compressed CSS, JS and HTML output for TYPO3
7 stars 8 forks source link

Check if asset is already processed #21

Closed pixeldasher closed 11 months ago

pixeldasher commented 11 months ago

While working with Fluid AssetCollecter, we noticed that external scripts were added or rather processed twice.

If an external script was embedded with the f:asset ViewHelper, the script was loaded once as "script-min.js.gz" and once as "script-min.js-min.gz.gz" in the frontend.

After some testing and turning off and on other extensions and TypoScript settings, this simple fix helped.

This fix obviously does not fix any problems but rather cures symptoms. It's just a quick little fix for a problem we encountered.

a-r-m-i-n commented 11 months ago

Hi @pixeldasher, thanks for providing the fix. How can I reproduce this issue?

a-r-m-i-n commented 11 months ago

Ah got it. You prepared the asset already, to be gzipped and tried to include it, with the asset collector.

a-r-m-i-n commented 11 months ago

I've solved it differently, so I had to close your PR. But the fix is released in version 3.0.1 of min extension.

Thanks :)

pixeldasher commented 11 months ago

Sorry for answering so late, but I'm happy that it's fixed!