search

a-r-m-i-n / pw_comments

Powerful TYPO3 CMS extension for providing comments, including replies on comments and votings, as well as mail notifications.
https://extensions.typo3.org/extension/pw_comments
0 stars 5 forks source link

Missing setAddQueryStringMethod in buildUriByUid? #7

Open darthnorman opened 1 year ago

darthnorman commented 1 year ago

There seems to be a line missing in the CommentController that was added here: https://github.com/a-r-m-i-n/pw_comments/commit/0bd2724c48d350b650d0842e103ecbd09a310681#diff-9f86396b2474664816ef991557f3a2a4ea7846ea4f5ed57eaf0a115fb8d88741R519

This line is no longer present and seems to be responsible for comments not working on news detail pages. Whenever I submit a comment I am landing on the correct page but the news is missing.

a-r-m-i-n commented 1 year ago

Oh. Sorry to hear. The reason why this line has been removed, is that this method has been dropped in UriBuilder.

What TYPO3 version are you using?

darthnorman commented 1 year ago

Hi, thanks for reaching out, I am using T3 v10.4.32 and tx_news v8.6.0

iamzero0 commented 1 year ago

Can confirm. When using pw_comments 5.2.0 with news 10.0.3 in TYPO3 10.4.37, after submitting a comment, users are redirected to the detail page without the single news parameters, i.e. /news/detail#comment1234 instead of /news/detail/news-item#comment1234

When adding ->setAddQueryStringMethod('GET') in the CommentController as @darthnorman mentioned it does seem to work correctly.