Closed cmbiwer closed 8 months ago
I ran the code on my end and things seem to work fine for me. It seems like this might be a multiprocessing issues. In the last line of the cell, could you try setting the npool
parameter equal to 1, instead of 10 to see if that fixes things? Thank you.
How do you recommend installing jupyter or whatever app to run the notebook? It seems some of these issues stem from me just installing the latest jupyter off conda.
How do you recommend installing jupyter or whatever app to run the notebook? It seems some of these issues stem from me just installing the latest jupyter off conda.
Hi @cmbiwer - I've now looked into this, and indeed, the issue arises when using a jupyter notebook whereas it runs fine on jupyter lab. I've reproduced your error by running:
conda create -n pygwb_for_joss python=3.9
git clone git@git.ligo.org:pygwb/pygwb.git
cd pygwb
pip install .
conda install jupyter
pip install ipykernel ipython==8.12.0 jupyter
ipython kernel install --name "pygwb_for_joss" --user
and using the pygwb_for_joss
environment. Whereas, if I run using jupyter lab
as we usually do, I get the same results as on the tutorial in the docs.
I think this is coming from a known bug/issue with multiprocessing on jupyter, see
I have now fixed the issue by just removing the multiprocessing call in the notebook, npool=10
. The example runs fast and doesn't actually need multiprocessing. I don't think it's worth having the example break when using notebooks, but we can add a note about it in the tutorials.
Thanks for looking into that. That is what I was doing.
but we can add a note about it in the tutorials.
I think that would be helpful and I'd be happy to close the issue and approve the JOSS submission.
Great - I've added a tip, see https://git.ligo.org/pygwb/pygwb/-/blob/master/tutorials/run_pe.ipynb
All merged.
In this demo: https://pygwb.docs.ligo.org/pygwb/run_pe.html#Combining-models
When I run this cell:
I get an error: