search

a-roomana / django-jalali-date

Jalali Date support for user interface. Easy conversion of DateTimeFiled to JalaliDateTimeField within the admin site, views, forms and templates.
MIT License
292 stars 33 forks source link

Resolve strftime type compatibility issue with jdatetime version 5 #80

Closed aminvsf closed 1 month ago

aminvsf commented 1 month ago

Resolve jdatetime 5 compatibility issue as described in https://github.com/a-roomana/django-jalali-date/issues/78.

aminvsf commented 1 month ago

@a-roomana

I added some tests for all three template tags. I also have created a pipeline which runs these tests against different Python, Django and Jdatetime versions to ensure they pass. This pipeline gets triggered whenever something is merged to master or a pull request is created against it.

For some reason GitHub didn't run these workflows at this repository at the moment (probably because it's a fork), so they will be activated after merging the code.

Although I created a test pull request in my own fork of this repository to ensure they pass. Here's the result: https://github.com/aminvsf/django-jalali-date/actions/runs/9303692234

aminvsf commented 1 month ago

@a-roomana

There was also another problem regarding this issue https://github.com/a-roomana/django-jalali-date/issues/76. This library isn't compatible with Python 3.12 since "distutils" package is removed since Python 3.12.

So I decided to temporary remove this Python version from our workflow in order for it to pass, but we need to consider solving this issue in the future.