search

a-schild / jave2

The JAVE (Java Audio Video Encoder) library is Java wrapper on the ffmpeg project
GNU General Public License v3.0
1.2k stars 245 forks source link

Added remove set and get globalOptions interfaces #181

Closed HANXU2018 closed 2 years ago

HANXU2018 commented 2 years ago

Added remove set and get globalOptions interfaces #180

fengxiaochuang commented 2 years ago

I am very lucky to see that the function I need has in the “pull-requests” area.

Before the release of version 3.3.0, package it or overwrite the class file by myself is the only fastest way, must not look like a best idea.

Will you release a new version recently?

paulvaneijden commented 2 years ago

A new release is highly anticipated for our project @a-schild

a-schild commented 2 years ago

Could you please test with the 3.3.0-SNAPSHOT release? If it's working for you I will release 3.3.0

paulvaneijden commented 2 years ago

I have successfully tested the 3.3.0-SNAPSHOT release

Unfortunately it can't find the ffmpeg executable, even when I build it myself. The error is: ! Causing: java.io.IOException: Cannot run program "/var/folders/mq/_bwp9j397mn6cb9705jbb2hh0000gn/T/jave/ffmpeg-x86_64-3.3.0-SNAPSHOT-osx": error=2, No such file or directory

When I look in that folder I only see my (previously installed) 3.2.0 executable. I had to hardcode this version into DefaultFFMPEGLocator to override the ws.schild.jave.Version

When I do that I am able to successfully test the 3.3.0-SNAPSHOT release with the currOptions parameter with the current example code:

final EncodingArgument encodingImageArgument = new ValueArgument(ArgType.OUTFILE, "-frames:v", encodingAttributes -> Optional.of("1"));
encoder.encode(List.of(new MultimediaObject(uploadedFile)), targetImage, attrsImage, null, List.of(encodingImageArgument))
a-schild commented 2 years ago

What do you mean by "Unfortunately it can't find the ffmpeg executable, even when I build it myself. " and above you tested it sucessfully?

paulvaneijden commented 2 years ago

What do you mean by "Unfortunately it can't find the ffmpeg executable, even when I build it myself. " and above you tested it sucessfully?

I mention that below that sentence :)

When I look in that folder I only see my (previously installed) 3.2.0 executable. I had to hardcode this version into DefaultFFMPEGLocator to override the ws.schild.jave.Version

When I do that I am able to successfully test the 3.3.0-SNAPSHOT release