search

a-schild / jave2

The JAVE (Java Audio Video Encoder) library is Java wrapper on the ffmpeg project
GNU General Public License v3.0
1.27k stars 249 forks source link

Can you make it a Maven Project ? #2

Closed goxr3plus closed 6 years ago

goxr3plus commented 6 years ago

There is no way to get JAVE with Maven anywhere ... trying to create a repository for it in order to get with Maven ....

https://github.com/goxr3plus/JAVE

Can you make this repository a Maven Project so it is more easy for the community please :) Love you too .

a-schild commented 6 years ago

Yep, will do it, but give me 1-2 weeks

goxr3plus commented 6 years ago

That's amazing. When you do it we can use https://jitpack.io/ website so it is very easy to add it as a dependency to any project.

goxr3plus commented 6 years ago

Something to discuss. Can we make it produce a jar which will contain ffmpeg for all 3 major desktop platforms ( Windowd, Linux, Mac) so it creates except of different jars, a fat one also.

Like actually the original JAVE jar which supports both Linux and Windows 32 bits at once in one jar.

a-schild commented 6 years ago

Yes,

I think a core + platform jars, and a fat one. All individual dependencies

goxr3plus commented 6 years ago

That's amazing!, so we can actually include the latest FFMPEG Versions also :). I tried to convert. opus and. spx with original JAVE from saurons software and got errors of no support.

goxr3plus commented 6 years ago

That will be very very big, gonna use it directly on XR3Player(https://github.com/goxr3plus/XR3Player) to support all the audio and video formats.

a-schild commented 6 years ago

Can you try the latest trunk version? You will need to download the repository and do a full build so it installs the maven artifacts locally. Then in your project, add jave-core in version 2.1.0-SNAPSHOT as a dependency and also the correct native version you require. You can also add all native dependencies, win+linux should work, OS-X not yet

It's completely untested for the moment

goxr3plus commented 6 years ago

I forked your project yesterday and made very big changes to it. Now it supports Java 8 and above, I transformed it on a Maven project, updated read me etc.

Have a look :)

https://github.com/goxr3plus/jave2

Currently it supports only Windows amd64.

I am trying to use the latest 4.0 FFMPEG.exe but when i replace the one you had before the program is not anymore running.

Also one more problem, the ProgressListener is not working at all on Jave2...

On Tue, Jun 12, 2018, 00:12 André Schild notifications@github.com wrote:

Can you try the latest trunk version? You will need to download the repository and do a full build so it installs the maven artifacts locally. Then in your project, add jave-core in version 2.1.0-SNAPSHOT as a dependency and also the correct native version you require. You can also add all native dependencies, win+linux should work, OS-X not yet

It's completely untested for the moment

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/a-schild/jave2/issues/2#issuecomment-396388853, or mute the thread https://github.com/notifications/unsubscribe-auth/ATbiwJiXmgJJOL0E0sGi48_1Jl5hEnS_ks5t7t0ogaJpZM4TkKKz .

a-schild commented 6 years ago

I have a current version with ffmpeg 3.4.2 which works fine now Also I included some first unit tests but there is a lot more which can be done.

Do you think we can already move on to ffmpeg 4.0?

goxr3plus commented 6 years ago

I love that you passed the project on Maven, i will fork it again i changed the code to not have the old depenfency in that logger from 2007.

How many new features FFMPEG4 includes?

On Wed, Jun 13, 2018, 23:30 André Schild notifications@github.com wrote:

I have a current version with ffmpeg 3.4.2 which works fine now Also I included some first unit tests but there is a lot more which can be done.

Do you think we can already move on to ffmpeg 4.0?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/a-schild/jave2/issues/2#issuecomment-397075376, or mute the thread https://github.com/notifications/unsubscribe-auth/ATbiwHl3bFOw4Ru5wpJJIb-qU_4WOgb9ks5t8XZSgaJpZM4TkKKz .

a-schild commented 6 years ago

Make a pull request with the new logger, I will include it

a-schild commented 6 years ago

What do you think, should I look to put the project in maven central? For this, I would however need to move the classes in a name space owned by me or my company.

The package names would then been like: ws.schild.jave or org.aarboard.jave

goxr3plus commented 6 years ago

You can make releases on Github . But it's completely okay if you put your name for Maven. With Github releases we can use Jitpack.io and grab them easily with Maven, Gradle etc. As you wish :)

On Thu, Jun 14, 2018, 19:11 André Schild notifications@github.com wrote:

What do you think, should I look to put the project in maven central? For this, I would however need to move the classes in a name space owned by me or my company.

The package names would then been like: ws.schild.jave or org.aarboard.jave

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/a-schild/jave2/issues/2#issuecomment-397350995, or mute the thread https://github.com/notifications/unsubscribe-auth/ATbiwAAyZfptFuAbLsAWKqjcRMit5d6bks5t8oslgaJpZM4TkKKz .

goxr3plus commented 6 years ago

I will make a pull request very soon.

On Fri, Jun 15, 2018, 16:16 GoXR3Plus Studio cralexcomp@gmail.com wrote:

You can make releases on Github . But it's completely okay if you put your name for Maven. With Github releases we can use Jitpack.io and grab them easily with Maven, Gradle etc. As you wish :)

On Thu, Jun 14, 2018, 19:11 André Schild notifications@github.com wrote:

What do you think, should I look to put the project in maven central? For this, I would however need to move the classes in a name space owned by me or my company.

The package names would then been like: ws.schild.jave or org.aarboard.jave

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/a-schild/jave2/issues/2#issuecomment-397350995, or mute the thread https://github.com/notifications/unsubscribe-auth/ATbiwAAyZfptFuAbLsAWKqjcRMit5d6bks5t8oslgaJpZM4TkKKz .

goxr3plus commented 6 years ago

Please drop a release for the latest Maven 2.3.0 version so i can use it with JitPack.io / https://jitpack.io/#a-schild/jave2

goxr3plus commented 6 years ago

ws.schild.jave is a good one :)