search

a-schild / nextcloud-java-api

Java api library to access nextcloud features from java applications
GNU General Public License v3.0
72 stars 50 forks source link

fixed parsing of missing user quotas (provided as "none") #72

Closed kriszman closed 3 years ago

a-schild commented 3 years ago

As this is a incompatible API change, we need to bump to version 12.0.0...

We could make a 11.7.x when we maintain a getQuota method with this signature: public long getQuota() { And return -1 when none is found/set

But then there is still the problem with all the XML variants of provisioning, which are droped/replaced by JSON. What do you think, go for 12.0.0?

kriszman commented 3 years ago

You're probably right and we'd better go for v12.0.0 then, in case we decide to drop XML support within the provisioning part in favor of JSON. I could take care of that and refactor the provisioning package in order to replace all of the XML answer handling to JSON answers. So far I've only been using the provisioning part of your library but I guess the mentioned changes shouldn't impact the other parts as the underlying, basic JSON handling has already been integrated. So if you're ok with that I would do the mentioned changes within the provisioning package using the existing tests and eventually enhance them in order to verify all of the refactoring I'm supposed to do then.

kriszman commented 3 years ago

@a-schild I created a new PR #73, so closing this one