search

a-sit-plus / kmm-vc-library

Kotlin Multiplatform library implementing W3C VC Data Model and ISO 18013-5 mDL
https://a-sit-plus.github.io/kmm-vc-library/
Apache License 2.0
15 stars 1 forks source link

Authentication response preparation helper #81

Closed acrusage-iaik closed 1 month ago

acrusage-iaik commented 1 month ago

Second try of https://github.com/a-sit-plus/kmm-vc-library/pull/67

Changes in OidcSiopWallet API:

Evaluating AuthenticationResponseResult is now a two-step-process:

  1. starting authentication response preparation - yields an authentication response preparation helper
  2. finalizing authentication response result - consumes an authentication response preparation helper

Between step 1 and step 2, users of the library may give their users a chance to consent and see submission details.

acrusage-iaik commented 1 month ago

regarding https://github.com/a-sit-plus/kmm-vc-library/pull/67#issuecomment-2149749995

I guess the issue is, that I always merged the changes from develop into this branch instead of rebasing. I am not sure how to get back to a clean state, should I just create a new branch from develop and copy the current state? This would result in 1 commit containing all the changes?

acrusage-iaik commented 1 month ago

@nodh @JesusMcCloud please re-review after incorporating changes from the development branch

acrusage-iaik commented 1 month ago

I guess I retreat from this massive pull request for now and split it up into smaller chunks, resolving conflicts after each merge into development takes way too much time..