Proper ASN.1 Tagging

[JesusMcCloud]

• Completely revamped ASN.1 Tag Handling
  • Properly handle multi-byte tags
  • Introduce a new data structure TLV.Tag with an accompanying TagClass enum and a constructed flag to accurately represent arbitrary tags up to ULong.MAX_VALUE
  • Make all tag parameters ULong to reflect support for multi-byte tags
  • Remove DERTags
  • Revamp implicit tagging (there is still work to be done, but at least it supports CONSTRUCTED ASN.1 elements)
• Refactor Int.Companion.decodeFromDer() -> Int.Companion.decodeFromDerValue()
• Refactor Long.Companion.decodeFromDer() -> Long.Companion.decodeFromDerValue()
• Introduce ULong.toAsn1VarInt() to encode ULongs into ASN.1 unsigned VarInts (not to be confused with multi^2_base'sUVarInt!)
• Introduce decodeAsn1VarULong() and decodeAsn1VarUInt() which can handle overlong inputs, as long as they start with a valid unsigned number encoding.
  • Comes in three ULong flavours:
  • Iterator<Byte>.decodeAsn1VarULong()
  • Iterable<Byte>.decodeAsn1VarULong()
  • ByteArray.decodeAsn1VarULong()
  • and three UInt flavours:
    • Iterator<Byte>.decodeAsn1VarUInt()
    • Iterable<Byte>.decodeAsn1VarUInt()
    • ByteArray.decodeAsn1VarUInt()

[nodh]

This encoding test fails for me:

"fails" {
        val it = 2204309167L
        val bytes = (it).toTwosComplementByteArray()
        val fromBC = ASN1Integer(it).encoded
        val long = Long.decodeFromDerValue(bytes)
        val encoded = Asn1Primitive(Asn1Element.Tag.INT, bytes).derEncoded
        encoded shouldBe fromBC
        long shouldBe it
    }

with

Expected :[2, 5, 0, -125, 99, 22, -81]
Actual   :[2, 6, 0, 0, -125, 99, 22, -81]

[JesusMcCloud]

This encoding test fails for me:

"fails" {
        val it = 2204309167L
        val bytes = (it).toTwosComplementByteArray()
        val fromBC = ASN1Integer(it).encoded
        val long = Long.decodeFromDerValue(bytes)
        val encoded = Asn1Primitive(Asn1Element.Tag.INT, bytes).derEncoded
        encoded shouldBe fromBC
        long shouldBe it
    }

with

Expected :[2, 5, 0, -125, 99, 22, -81]
Actual   :[2, 6, 0, 0, -125, 99, 22, -81]

@iaik-jheher i thought you fixed it?

[JesusMcCloud]

decodeTag is broken!. encoding works perfectly fine though, so debugging should be easy

[JesusMcCloud]

decodeTag is broken!. encoding works perfectly fine though, so debugging should be easy

was varint decoding bug. fixed now

[iaik-jheher]

decodeTag is broken!. encoding works perfectly fine though, so debugging should be easy

was varint decoding bug. fixed now

did you add a test case that covers this, since it was not caught before?

[JesusMcCloud]

decodeTag is broken!. encoding works perfectly fine though, so debugging should be easy

was varint decoding bug. fixed now

did you add a test case that covers this, since it was not caught before?

totally forgot do test for trainlign bytes. now there's a testcase for longs and ints and both caught the error