Remove requirement from CSR to have certificate extensions

a-sit-plus / signum

Kotlin Multiplatform Crypto/PKI Library and ASN1 Parser + Encoder

https://a-sit-plus.github.io/signum/

Apache License 2.0

76 stars 6 forks source link

Remove requirement from CSR to have certificate extensions #157

Closed JesusMcCloud closed 1 month ago

JesusMcCloud commented 1 month ago

fixes #156

iaik-jheher commented 1 month ago

can you reference the relevant rfc for me?

JesusMcCloud commented 1 month ago

There you go: https://datatracker.ietf.org/doc/html/rfc2986

I was not about to exclude you, it's just that I'm pretty sure @nodh knows more about this stuff than the both of us combined, so I was going for efficiency

nodh commented 1 month ago

Then you might as well make the parameter optional?

extensions: List<X509CertificateExtension>,

JesusMcCloud commented 1 month ago

your suggestion actually made me catch a bug, that now has a testcase for ;-)