search

a-sit-plus / signum

Kotlin Multiplatform Crypto/PKI Library and ASN1 Parser + Encoder
https://a-sit-plus.github.io/signum/
Apache License 2.0
76 stars 6 forks source link

Optimize library size #173

Closed CoreFloDev closed 3 weeks ago

CoreFloDev commented 1 month ago

Hi,

I have noticed that on android it ship with multiples files that aren't accessible: org/bouncycastle/pqc/crypto/picnic/lowmcL5.bin.properties org/bouncycastle/pqc/crypto/picnic/lowmcL3.bin.properties org/bouncycastle/pqc/crypto/picnic/lowmcL1.bin.properties org/bouncycastle/x509/CertPathReviewerMessages_de.properties org/bouncycastle/x509/CertPathReviewerMessages.properties org/bouncycastle/pkix/CertPathReviewerMessages_de.properties org/bouncycastle/pkix/CertPathReviewerMessages.properties

Those files adds a total of 1.2MB to the apk size and aren't accessible to the android application, would it be possible to remove those files from the library ?

Thanks

JesusMcCloud commented 1 month ago

Thanks for the report!

Am I correct that this is simply a resource.excludes.add for each of these?

CoreFloDev commented 1 month ago

That's what I use on my end yes

JesusMcCloud commented 3 weeks ago

closed with #176