search

a-sit-plus / vck

Kotlin Multiplatform library implementing W3C VC Data Model and ISO 18013-5 mDL
https://a-sit-plus.github.io/vck/
Apache License 2.0
29 stars 2 forks source link

OAuth DPoP #125

Closed nodh closed 2 months ago

nodh commented 2 months ago

I'm also thinking about extracting that token functionality from WalletService, but this would be better suited in a future PR.

n0900 commented 2 months ago

Jvm Build fails but tests succeed? Implementation looks good to me.

nodh commented 2 months ago

Jvm Build fails but tests succeed? Implementation looks good to me.

e: file:///home/runner/work/vck/vck/vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt:738:9 No parameter with name 'httpMethod' found.

@JesusMcCloud shouldn't this be a composite build, with the checked-in code from the submodule?

JesusMcCloud commented 2 months ago

So apparently, the jvmTest action disables composite builds. I've now reverted this change, BUT we need to have a strategy for testing releases. My proposal: Introduce an allTests action that disables composite builds, which will run only on release/xxx branches an main. D'Accord?!

FYI: snapshot publishing works now for Signum, so we can depend on the actual version catalogs of the signum commit included in the composite build. We should, however, pin this snapshot version to a specific build (e.g. 4.0.0-20240917.201628-3 for indispensable and 0.3.0-20240917.201628-6 for Supreme. if you agree, just assign me an issue with reference to this comment.