a-ws-m / unlockNN

A Python package for adding uncertainties to neural network models of chemical systems.
MIT License
24 stars 7 forks source link

Code coverage is fairly low #26

Open pmeier opened 3 years ago

pmeier commented 3 years ago

Although the coverage is 78%, the tests cover very little apart from the regular cases. A lot of if branches especially in error cases are not covered. Additionally, the following functions and modules are not covered at all:

a-ws-m commented 3 years ago

I've added the following changes:

I think default_megnet_config() doesn't require a test. It comes from the authors of MEGNet and essentially works to abstract a very common combination of keyword arguments into a one-liner. Because of the nature of the function (essentially, it's a parameterizable dictionary) I can't think of a useful test to be run.