Refactor/class to func component

a-x- / react-easy-print

Powerful react component for easy printing

https://www.npmjs.com/package/react-easy-print

MIT License

87 stars 19 forks source link

Open Vitao18 opened 4 years ago

Vitao18 commented 4 years ago

Closes #43

sibelius commented 4 years ago

@a-x- can you help us review this?

Vitao18 commented 4 years ago

I'll check the comments and suggestions and work on the changes later Thanks for the valuable input, very glad to help

a-x- commented 4 years ago

https://github.com/a-x-/react-easy-print/pull/44#pullrequestreview-321913619, @sibelius: I don’t think this influence the react devtool

Heh, looks you're right

It's because of babel preset react:

👆

sibelius commented 4 years ago

@a-x- any progress on this?

anything we can do to help?

Vitao18 commented 4 years ago

@a-x- Hey, anything I can do to help to get this merged? I'll check the refactor again to see if there's something missing

Just let me know :)

sibelius commented 4 years ago

can we merge and release a new version?

it would be cool to add some react-testing-library tests after this