search

a0x8o / kafka

A high-throughput, distributed, publish-subscribe messaging system
Apache License 2.0
67 stars 172 forks source link

SslConfigs SSL_PROTOCOL_CONFIG wrong value #33

Closed stomashchuk closed 2 years ago

stomashchuk commented 2 years ago

SSL_PROTOCOL_CONFIG property in class SslConfigs has value "ssl.protocol". But for ssl connection to kafka we need to use "security.protocol" value.

OneCricketeer commented 2 years ago

Please use JIRA to report Kafka project issues

https://issues.apache.org/jira/browse/KAFKA

OneCricketeer commented 2 years ago

Besides, you're using the wrong config class

https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java#L99

stomashchuk commented 2 years ago

Hi Jordan. Thank you for your reply. Ok, sorry. Apparently I didn't pay enough attention to reading documentation. Could I ask one question - why don't class, that you mentioned, contains truststore, keystore parameters?

OneCricketeer commented 2 years ago

Security protocol is not unique to SSL, so it is in the CommonConfigs

The ssl key/truststore settings are specific to SSL, and so are in the SSLConfigs class

https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java#L70

stomashchuk commented 2 years ago

Thank you very much for your answers. Good luck )