a11ySea / testing

Collect accessibility issues for public websites
3 stars 3 forks source link

King County COVID19 - Bug: Language attributes are missing for the languages in the middle of the page #6

Open lamarjordanux opened 4 years ago

lamarjordanux commented 4 years ago

Issue Summary

Screen readers may not announce the language properly without lang attributes.

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to one of the language buttons in the middle of the page
  2. Inspect the button code

Behavior

Expected behavior

Screen reader pronounces the language in native tongue.

Actual behavior

Versions

Device Information:

Screen Reader or AT Information

Screenshots

If applicable, add screenshots to help explain your problem.

Code

Current Code

(code snippet)

Suggested Code

(code snippet)

Specifications

Additional References

dpersing commented 4 years ago
Screenshot of the language controls
alboss commented 4 years ago

Current code: <a class="btn btn-primary btn-block" href="/depts/health/covid-19/languages/spanish.aspx" role="button" data-toggle="tooltip" data-placement="left" title="" data-original-title="COVID-19 Recomendaciones de Salud Pública">Spanish <span class="fas fa-long-arrow-alt-right" aria-hidden="true"></span> Español</a>

Suggested code: <a class="btn btn-primary btn-block" href="/depts/health/covid-19/languages/spanish.aspx" role="button" data-toggle="tooltip" data-placement="left" title="" data-original-title="COVID-19 Recomendaciones de Salud Pública">Spanish <span class="fas fa-long-arrow-alt-right" aria-hidden="true"></span> <span lang="es">Español</span></a>

What changed? Español is now <span lang="es">Español</span> so a text reader will read it as a Spanish word instead of sounding it out as an English word and mispronouncing it.

Impact: Essential for text readers.

Difficulty of change: tedious but not difficult.