search

a11yproject / a11yproject.com

The A11Y Project is a community-driven effort to make digital accessibility easier.
https://a11yproject.com
Apache License 2.0
3.7k stars 551 forks source link

feat: incorporate variables into existing spacing utility classes #1564

Closed ttkapostol closed 1 year ago

ttkapostol commented 1 year ago

Hello!

We have tried to fix the issue #934 as part of an Open Source Event in Madrid. We have incorporated all repeated measurements in variables. The variables were created according to this table:

Declaration of common measurements for margin and padding $m-0: 0rem $m-1: 0.5rem $m-2: 1rem $m-3: 1.5rem $m-4: 2rem $m-5: 2.5rem $m-6: 3rem $m-7: 3.5rem $m-8: 4rem $m-9: 4.5rem $m-10: 5rem $m-11: 5.5rem $m-12: 6rem

Then we created $m- for margin $mt- for margin-top, $mr- for margin-right, $mb- for margin-bottom and $ml- for margin-left. Also, $p- for padding and the rest according to this logic.

We hope to hear from you soon and collaborate more with you in the future.

SaptakS commented 1 year ago

I will take a look at this and review soon.

ttkapostol commented 1 year ago

I will take a look at this and review soon.

We are sorry, we just realised there is a mistake in the declaration, we are correcting it right now and we will make another pr.