search

a11yproject / a11yproject.com

The A11Y Project is a community-driven effort to make digital accessibility easier.
https://a11yproject.com
Apache License 2.0
3.7k stars 551 forks source link

Issue#934 #1565

Open ttkapostol opened 1 year ago

ttkapostol commented 1 year ago

Hello!

We have tried to fix the issue https://github.com/a11yproject/a11yproject.com/issues/934 as part of an Open Source Event in Madrid. We have incorporated all repeated measurements in variables. The variables were created according to this table:

Declaration of common measurements for margin and padding $m-0: 0rem $m-1: 0.5rem $m-2: 1rem $m-3: 1.5rem $m-4: 2rem $m-5: 2.5rem $m-6: 3rem $m-7: 3.5rem $m-8: 4rem $m-9: 4.5rem $m-10: 5rem $m-11: 5.5rem $m-12: 6rem

(Padding is obviously the same but substituting m for p.)

We hope to hear from you soon and collaborate more with you in the future.

ttkapostol commented 1 year ago

We have tried fixing the following errors:

10:49:28 AM: 12:12 ✖ Expected newline after ":" with a multi-line declaration declaration-colon-newline-after 10:49:28 AM: src/css/components/_c-featured.scss 10:49:28 AM: 17:12 ✖ Expected newline after ":" with a multi-line declaration declaration-colon-newline-after 10:49:28 AM: src/css/components/_c-form.scss 10:49:28 AM: 70:13 ✖ Expected newline after ":" with a multi-line declaration declaration-colon-newline-after 10:49:28 AM: src/css/components/_c-linkroll.scss 10:49:28 AM: 13:12 ✖ Expected newline after ":" with a multi-line declaration declaration-colon-newline-after 10:49:28 AM: src/css/components/_c-recommended-reading.scss 10:49:28 AM: 34:12 ✖ Expected newline after ":" with a multi-line declaration declaration-colon-newline-after 10:49:28 AM: src/css/vendor/_v-toc.scss 10:49:28 AM: 143:13 ✖ Expected newline after ":" with a multi-line declaration declaration-colon-newline-after 10:49:28 AM: 144:63 ✖ Expected newline after "," in a multi-line list value-list-comma-newline-after 10:49:28 AM: [08:49:28] 'lintStyles' errored after 4.74 s 10:49:28 AM: [08:49:28] Error in plugin "gulp-stylelint"

And leave formatting as you had it previously. However, they still appear in our terminal.

Plus, we didn't do the npm run publish because we didn´t want to deploy. We were just tring to create unified variables for margins and paddings.

Hope this helps you!

davatron5000 commented 1 year ago

@ttkapostol Thanks for the work on this. Those errors are minor but are preventing the site from building a preview. I think it's maybe an issue with character encodings? Or a formatter gone wild.

I'll have a fix for this in a bit that hopefully let's the site build. Are you on Windows?

ttkapostol commented 1 year ago

@ttkapostol Thanks for the work on this. Those errors are minor but are preventing the site from building a preview. I think it's maybe an issue with character encodings? Or a formatter gone wild.

I'll have a fix for this in a bit that hopefully let's the site build. Are you on Windows?

Thank you very much @davatron5000 !

SaptakS commented 1 year ago

@davatron5000 are you going to review this? Else I am happy to review it some time around end of this week.

davatron5000 commented 1 year ago

@SaptakS If you don't mind taking a look. I'll try to review it as well. Sorry this has taken so long.

So far it looks good to me. Pretty straight forward.

SaptakS commented 1 year ago

Will do.

SaptakS commented 10 months ago

Ideally, I would also want to reduce the number of variables and maybe normalize some of the spacing to avoid having to need so many different variables