Closed flipthewho closed 1 day ago
Hello @flipthewho,
Thanks for your pull request!
Please see my review below.
@flipthewho, it would be nice if you provide the testcases for your arch detection.
You can add them to the functional test .github/workflows/functional_test.sh.
Testing detect_arch_kconfig()
would be appreciated as well.
hello, @a13xp0p0v! i guess i`m done
Excellent! Thank you @flipthewho. Merged.
much thanks, @a13xp0p0v! had an interesting case)
implementation of of issue #158
some sysct checks depend on the microarchitecture, for example: #157
what i did:
detect_arch()
intodetect_arch_kconfig()
detect_arch_sysctl()
.now we can parse the
kernel.arch
sysctl to determine the arch.