a13xp0p0v / kernel-hardening-checker

A tool for checking the security hardening options of the Linux kernel
GNU General Public License v3.0
1.67k stars 152 forks source link

implementation of `detect_arch_sysctl()` #161

Closed flipthewho closed 1 day ago

flipthewho commented 4 weeks ago

implementation of of issue #158

some sysct checks depend on the microarchitecture, for example: #157

what i did:

now we can parse the kernel.arch sysctl to determine the arch.

a13xp0p0v commented 3 weeks ago

Hello @flipthewho,

Thanks for your pull request!

Please see my review below.

a13xp0p0v commented 2 weeks ago

@flipthewho, it would be nice if you provide the testcases for your arch detection.

You can add them to the functional test .github/workflows/functional_test.sh.

Testing detect_arch_kconfig() would be appreciated as well.

flipthewho commented 1 week ago

hello, @a13xp0p0v! i guess i`m done

a13xp0p0v commented 1 day ago

Excellent! Thank you @flipthewho. Merged.

flipthewho commented 1 day ago

much thanks, @a13xp0p0v! had an interesting case)