Finish migrating to wasm-safe JS-interop

a14n / dart-google-maps

A library to use Google Maps JavaScript API v3 from Dart scripts.

Apache License 2.0

130 stars 66 forks source link

Finish migrating to wasm-safe JS-interop #125

Closed kevmoo closed 4 months ago

kevmoo commented 9 months ago

Sadly, v7.1.0 is still not ready for wasm.

js_wrapping is outdated and still uses pkg:js. There is still a dependency on pkg:js.

kevmoo commented 9 months ago

How can we help here? Seems like js_wrapping is the culprit!

a14n commented 8 months ago

This is a real big task. Not sure to have enough free time in the next days/weeks :-/

kevmoo commented 8 months ago

@a14n – you've been a MACHINE here. Thanks for clearly communicating your limitations!

JgomesAT commented 7 months ago

We have some conflicts with libraries of use of package js the major part of libraries are updated to use js 0.7 but Google maps uses 0.6 is it possible to update to version 0.7.1?

a14n commented 7 months ago

I started working on a new version but it is a full rewrite and will take some time for it to land.

kevmoo commented 7 months ago

Any updates here @a14n ? anyway we can help?

a14n commented 7 months ago

I started a new generator based on scraping/parsing https://developers.google.com/maps/documentation/javascript/reference/.

There are some challenges:

regarding types: e.g Dart type to use for JS union type like LatLng|LatLngLiteral ?
type conversion to Dart
trying to reduce changes to do for the migration
dartify the api like the current google_maps package

I don't have a lot of free time to work on it. I will try to push some code on a branch once I have something clean.

MagnusJohansson commented 7 months ago

I'm also waiting for an update that addresses the dependency on the 3 year old js ^0.6.3, starting to get conflicts with other packages that uses 0.7.1.

I have also seen this, that might need to be taken into consideration for future updates. Important: Prefer using dart:js_interop instead of this package for JS interop. See the [JS interop documentation](https://dart.dev/interop/js-interop) for more details.

bziembanski commented 6 months ago

Also having problems with old js version. I would really appreciate new resolved version

a14n commented 6 months ago

A little update on this migration/rewrite. I made great progress and it's close to have a pre-version to test. If someone is crazy enough to give it a stab the code lives in the new-js-interop branch. WARNING this is a working branch where force-pushes occurs regularly.

Rexios80 commented 5 months ago

This was expected, but the new google_maps code is not a drop in replacement for the old version for anyone thinking of trying it

a14n commented 4 months ago

It took a long time but I just published google_maps-8.0.0-dev.1.

To migrate, here are the main points:

GMap should be rename to Map
toJS and toDart are sometimes required on elements accepting/returning several types
some services now return Future instead of having a callback function

kevmoo commented 4 months ago

amazing! thank you! We'll try it out.

Rexios80 commented 4 months ago

@kevmoo do you have a designated person to do the migration? If not I can try and do it.

kevmoo commented 4 months ago

@Rexios80 – want to run on this? https://github.com/flutter/packages/pull/7064

Rexios80 commented 4 months ago

Sure! I can take a look next week.

Rexios80 commented 4 months ago

@a14n I almost have a fully working version of google_maps_flutter using this new google_maps version here: https://github.com/flutter/packages/pull/7077

Thanks for the awesome work!

I just had a few issues I resolved in https://github.com/a14n/dart-google-maps/pull/132 along with one issue I mentioned there that I have been unable to resolve without help. Please take a look when you get a chance.

a14n commented 4 months ago

Done via google_maps-8.0.0