search

a14n / dart-google-maps

A library to use Google Maps JavaScript API v3 from Dart scripts.
Apache License 2.0
130 stars 66 forks source link

A release with "migrate from dart:js to package:js" please #84

Closed gustav3d closed 3 years ago

gustav3d commented 4 years ago

Hello,

I would like to test the "migrate from dart:js to package:js" commit with the https://pub.dev/packages/flutter_google_maps project .

But it seems not possible to upgrade a sub dependency to a git source.

Can you make a new release ?:)

best regards Gustav

a14n commented 4 years ago

It's still a work in progress because I'd like to investigate/address some issues.

Unfortunatelly I had to put this work aside for some times. Hope to find time to work on it in the next weeks/month.

gustav3d commented 4 years ago

Thanks for the quick response. Alright, I understand.

Are there any currently known issues with it ?.

On Mon, 15 Jun 2020 at 15:19, Alexandre Ardhuin notifications@github.com wrote:

It's still a work in progress because I'd like to investigate/address some issues.

Unfortunatelly I had to put this work aside for some times. Hope to find time to work on it in the next weeks/month.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/a14n/dart-google-maps/issues/84#issuecomment-644130200, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABCY4OGRCS3AW7TSY4HSBDRWYNW3ANCNFSM4N6FLLDA .

a14n commented 4 years ago

IIRC there are 2 main issues:

gustav3d commented 4 years ago

Thanks for the explanation of the situation.

I would like to delve into this, but I'm overwhelmed with work by being alone in my current project :(

On Mon, 15 Jun 2020 at 15:32, Alexandre Ardhuin notifications@github.com wrote:

IIRC there are 2 main issues:

  • every callback needs to be wrap with allowInterop and I'd like to automatically do that (but it's not possible for contructor and static methods)
  • issues with enums and their underlying types. I'd like to avoid using dynamic/Object but it's the only workaround I found for now.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/a14n/dart-google-maps/issues/84#issuecomment-644137145, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABCY4OZYYWKXMOJGQTPQYDRWYPGJANCNFSM4N6FLLDA .

carloshwa commented 4 years ago

Would it be possible to rebuild the v3 branch against the latest Google Maps JS library? It looks like it's currently built against an older version, and there are some missing APIs (specifically looking at the Autocomplete library). Or are there steps so that we can re-build it ourselves locally?

a14n commented 4 years ago

Unfortunately the v3 branch was build with something that is completely broken today. To make some changes I have to make manual changes (and that's not always simple)

a14n commented 3 years ago

Version 4.0.0 is published