search

a14n / dart-google-maps

A library to use Google Maps JavaScript API v3 from Dart scripts.
Apache License 2.0
130 stars 66 forks source link

Property className in MarkerLabel #96

Closed alexd1971 closed 3 years ago

alexd1971 commented 3 years ago

Is it possible to release v3.4.6 with property className in MarkerLabel? Unfortunately I cannot utilise v4.0.0 because of using extensions for most classes what makes it impossible to inherit from them.

a14n commented 3 years ago

This change is not enough to make it work. You need to add the following change to https://github.com/a14n/dart-google-maps/blob/912a74365babeebf2af8e7c52277fb3133ae5ab1/lib/src/google_maps_src.g.dart#L3651-L3680

  String get className => asJsObject(this)['className'];
  set className(String _className) {
    asJsObject(this)['className'] = _className;
  }

But you can also do that without a new release of the v3 branch:

MarkerLabel markerLabel = ....;
asJsObject(markerLabel)['className'] = 'awesome';

So, is a new release really necessary? (I don't really want to maintain 2 branches)

alexd1971 commented 3 years ago

Thanks. I've utilised your suggestion.

a14n commented 3 years ago

Thanks for your feedback. I close this PR.